@eshemon @kkiesling FYI

Job Documentation, step Docs: sync website on 6159314 wanted to post the following:

View the site here

This comment will be updated on new commits.

Job Coverage, step Generate coverage on 6159314 wanted to post the following:

Framework coverage

Diff coverage report

Full coverage report

Modules coverage

Reactor

Diff coverage report

Full coverage report

Full coverage reports

This comment will be updated on new commits.

@GiudGiud this PR should be good to review 🙏🏾

I think we should make some sort of "tester" for the CSG, to ensure it is valid

this could be checking volumes? Or simplifying them and making sure a region is not empty? (intersection of +plane and -plane for example) ? or make a converter to OpenMC so the reviewer can plot them there?

@GiudGiud Unfortunately, this is not necessarily within scope of the funded work that @shikhar413 and I currently doing. Yes, having some sort of visualization would be helpful as a developer, but that will also naturally come as the connection to specific codes are developed and each code has its native visualization tool that can be used. Additionally, Ideally tests are written in small enough units that the output can be manually inspected by developers/reviewers for correctness (which it seems you were able to do here, noting the mistake), and then they cover enough cases to be able to trust the larger complex models are correct.

Also, this CSG framework is not necessarily meant to check the validity of a CSG model, but instead makes sure it matches whatever input it was given. We are operating under the assumption that MOOSE has already validated the input as valid, and therefore if the CSG model is made to match that correctly, it is also valid. So in the example of an empty region, if that is what is created by the MOOSE input and valid there, then that is what would be created and considered valid for CSG as well.

Let us know if you want to discuss this in more detail offline/in a meeting.

Job Precheck, step Clang format on a7c8afe wanted to post the following:

Your code requires style changes.

A patch was auto generated and copied here
You can directly apply the patch by running, in the top level of your repository:

curl -s https://mooseframework.inl.gov/docs/PRs/31782/clang_format/style.patch | git apply -v

Alternatively, with your repository up to date and in the top level of your repository:

git clang-format 2acb415a170285fef37748f90025af38c3977b3c

@GiudGiud this should be good for a re-review now

@GiudGiud comments should be addressed now. @kkiesling also brought up that we should have a unit test for testing the clone method, so I added that along with equality operator definitions for CSGBase and CSG[Surface|Universe|Cell]List.

Job Test, step Results summary on 6159314 wanted to post the following:

Framework test summary

Compared against 7edd10c in job civet.inl.gov/job/3374418.

Added tests

Modules test summary

Compared against 7edd10c in job civet.inl.gov/job/3374418.

Added tests

Thanks @GiudGiud